Upgrade daphne-server to http 1 #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendess
requested review from
armfazh,
bhalleycf,
cjpatton and
fisherdarling
as code owners
mendess
requested review from
cbranch,
lbaquerofierro,
Noah-Kennedy,
RageKnify and
jhoyla
as code owners
mendess
force-pushed
the
mendess/upgrade-to-http-1
branch
from
3072f17 to
2800ab7
Compare
mendess
force-pushed
the
mendess/upgrade-to-http-1
branch
2 times, most recently
from
9572f3e to
7f43f65
Compare
armfazh
approved these changes
Nov 22, 2024
| @@ -177,7 +175,7 @@ where | |||
|
|
|||
| // TODO(mendess): this allocates needlessly, if prio supported some kind of | |||
| // AsyncParameterizedDecode we could avoid this allocation | |||
| let payload = hyper::body::to_bytes(body).await; | |||
| let payload = axum::body::to_bytes(body, usize::MAX).await; | |||
There was a problem hiding this comment.
we may want to only accept a certain amount of bytes based on the payload we are expecting. currently this is not supported, right?
There was a problem hiding this comment.
Yes, I'm gonna open an issue. The previous implementation didn't allow limiting this so I kept it "the same" but we should investigate if we can deduce a sane limit we can put here
mendess
force-pushed
the
mendess/upgrade-to-http-1
branch
4 times, most recently
from
6c1d3d8 to
2596cf6
Compare
mendess
force-pushed
the
mendess/upgrade-to-http-1
branch
from
ffea5c1 to
20895c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to http 1 and axum 0.7, which is a breaking change but for us means a simplification of the code as we no longer have to care about the Body of a request, it is now
axum::body::Bodyinstead of being generic.