Rename transition failure to report error #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoyla
requested review from
armfazh,
bhalleycf,
cjpatton,
fisherdarling,
cbranch,
lbaquerofierro,
mendess,
Noah-Kennedy and
RageKnify
as code owners
mendess
reviewed
Dec 17, 2024
jhoyla
force-pushed
the
jhoyla/bump-vdaf-prio2
branch
from
edc8714 to
cdb08ac
Compare
jhoyla
force-pushed
the
jhoyla/rename-transition-failure-to-report-error
branch
from
5241e5e to
bd39e6e
Compare
jhoyla
force-pushed
the
jhoyla/bump-vdaf-prio2
branch
from
e317838 to
22e98cb
Compare
jhoyla
force-pushed
the
jhoyla/rename-transition-failure-to-report-error
branch
from
bd39e6e to
be3cf14
Compare
mendess
approved these changes
Dec 18, 2024
cjpatton
requested changes
Dec 18, 2024
jhoyla
force-pushed
the
jhoyla/rename-transition-failure-to-report-error
branch
from
be3cf14 to
cf26cc2
Compare
jhoyla
changed the base branch from
jhoyla/bump-vdaf-prio2
to
jhoyla/bump-vdaf-prio2-take-2
jhoyla
force-pushed
the
jhoyla/rename-transition-failure-to-report-error
branch
from
cf26cc2 to
2976ef4
Compare
cjpatton
approved these changes
Dec 19, 2024
jhoyla
force-pushed
the
jhoyla/bump-vdaf-prio2-take-2
branch
from
5f97e29 to
39b1183
Compare
jhoyla
force-pushed
the
jhoyla/rename-transition-failure-to-report-error
branch
from
2976ef4 to
0c0fcc1
Compare
jhoyla
force-pushed
the
jhoyla/bump-vdaf-prio2-take-2
branch
2 times, most recently
from
9ee98c1 to
9065eec
Compare
jhoyla
force-pushed
the
jhoyla/rename-transition-failure-to-report-error
branch
from
0c0fcc1 to
5611fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In draft 13 of the DAP spec
PrepareError(which we calledTransitionFailure) was renamed toReportError. This PR brings us in line with the spec.