taskprov: Ensure the task ID matches the advertised config #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
armfazh,
bhalleycf,
fisherdarling,
cbranch,
lbaquerofierro,
mendess,
RageKnify and
jhoyla
as code owners
mendess
approved these changes
Dec 19, 2024
Add a unit test that ensures `TaskprovAdvertisement::parse_taskprov_advertisement()` fails if the task ID doesn't match the advertised task config. Along the way, adjust some variable names to make the code easier to read.
cjpatton
force-pushed
the
cjpatton/710-no-bug
branch
from
127fd39 to
24eb0aa
Compare
|
Took Mendes' suggestion, rebased, and squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #710.
Add a unit test that ensures
TaskprovAdvertisement::parse_taskprov_advertisement()fails if the task ID doesn't match the advertised task config. Along the way, adjust some variable names to make the code easier to read.