Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make quiche-client respect concurrency limits passed via CLI #1619

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Make quiche-client respect concurrency limits passed via CLI #1619

wants to merge 3 commits into from

Conversation

evanrittenhouse
Copy link
Contributor

@evanrittenhouse evanrittenhouse commented Sep 17, 2023 •
edited
Loading

Tested by spinning up a quiche-server instance and then running:

RUST_LOG=trace cargo run --bin quiche-client -- https://127.0.0.1:4433 --no-verify --requests 50 --concurrent-requests <concurrent_requests>

with concurrent_requests set to 1, 5,and 50. I then ensured that the trace log I added got printed in the expected cases. I also:

  1. added a print to check self.reqs_in_flight and ensured that it was always less than or equal to the concurrent_requests limit.
  2. Ensured that 50/50 responses were received.

@evanrittenhouse evanrittenhouse requested a review from a team as a code owner September 17, 2023 19:28
@evanrittenhouse evanrittenhouse force-pushed the evanrittenhouse/quiche_client_concurrency branch from fda4aae to 45c46b5 Compare September 18, 2023 14:05
LPardue
LPardue reviewed Oct 13, 2023
View reviewed changes
apps/src/args.rs Outdated Show resolved Hide resolved
apps/src/common.rs Outdated Show resolved Hide resolved
@evanrittenhouse evanrittenhouse force-pushed the evanrittenhouse/quiche_client_concurrency branch 3 times, most recently from 73f8aad to 668e828 Compare October 14, 2023 16:36
@evanrittenhouse evanrittenhouse force-pushed the evanrittenhouse/quiche_client_concurrency branch from 668e828 to ecf6dcf Compare October 14, 2023 16:38
LPardue
LPardue reviewed Oct 14, 2023
View reviewed changes
apps/src/args.rs Show resolved Hide resolved
apps/src/common.rs Outdated Show resolved Hide resolved
LPardue
LPardue requested changes Oct 20, 2023
View reviewed changes
apps/src/common.rs Outdated Show resolved Hide resolved
apps/src/common.rs Outdated Show resolved Hide resolved
apps/src/common.rs Outdated Show resolved Hide resolved
apps/src/common.rs Outdated Show resolved Hide resolved
quiche/src/lib.rs Outdated Show resolved Hide resolved
apps/src/common.rs Outdated Show resolved Hide resolved
@evanrittenhouse evanrittenhouse force-pushed the evanrittenhouse/quiche_client_concurrency branch from ca5245f to fa64555 Compare November 3, 2023 21:49
@evanrittenhouse evanrittenhouse marked this pull request as draft November 3, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPardue LPardue LPardue requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanrittenhouse @LPardue