Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: macOS M1 architecture #1645

Merged
merged 1 commit into from
Apr 10, 2024
Merged

CI: macOS M1 architecture #1645

merged 1 commit into from
Apr 10, 2024

Conversation

junhochoi
Copy link
Contributor

Add macos-latest-xlarge target for building on Apple Sillicon macOS.

@junhochoi junhochoi requested a review from a team as a code owner November 10, 2023 01:18
@junhochoi junhochoi force-pushed the junho/ci-m1-mac branch 2 times, most recently from ebfba40 to 4719c81 Compare November 10, 2023 01:26
@junhochoi
Copy link
Contributor Author

This new job failed with:

The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings.

Probably because this m1 runner is paid one.

@junhochoi junhochoi force-pushed the junho/ci-m1-mac branch 2 times, most recently from 774027e to 70d359a Compare November 10, 2023 01:39
@junhochoi
Copy link
Contributor Author

junhochoi commented Nov 10, 2023 •
edited
Loading

This new job failed with:

The job was not started because recent account payments have failed or your spending limit needs to be increased. Please check the 'Billing & plans' section in your settings.

Probably because this m1 runner is paid one.

It works on my account : https://github.com/junhochoi/quiche/actions/runs/6819661072/job/18547366616
after increasing my Action limit (default 0 -> some $ amount) to run this.

And it's very fast!. Total time for macos-latest (Intel): 3m41s vs macos-latest-xlarge (m1): 1m14s (3x faster)
(Yes faster probably because this is xlarge instance)

I'll let the maintainers to take a look since this PR needs a paid feature.

@glandium
Copy link
Contributor

glandium commented Feb 2, 2024

You can use macos-14 now.

@junhochoi
Copy link
Contributor Author

junhochoi commented Feb 2, 2024 •
edited
Loading

You can use macos-14 now.

Thanks! I updated the PR to use macos-14. The build is green now.

Perf (build time) looks great.

  • macos-latest (x86_64): 5m3s
  • macos-14 (aarch64): 1m42s

@ghedo ghedo force-pushed the junho/ci-m1-mac branch from d823f48 to f44e94a Compare March 16, 2024 05:46
@junhochoi
CI: macOS M1 architecture
9fcaae6 
Add `macos-14` target for building on Apple Silicon (M1)
macOS.

See the following url for details:
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
@junhochoi
Copy link
Contributor Author

rebased.

@ghedo ghedo merged commit d1c44fc into cloudflare:master Apr 10, 2024
26 checks passed
@ghedo
Copy link
Member

ghedo commented Apr 10, 2024

Sorry for the delay, this merged now, thanks @junhochoi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushilmehra rushilmehra rushilmehra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@junhochoi @glandium @ghedo @rushilmehra