Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quiche_conn_new_scid(...) implementation #1670

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

normanmaurer
Copy link
Contributor

Motivation:

The implementation of quiche_conn_new_scid(...) made it impossible to know if the call was a success or not as even on a sucessfull call it might return a negative value.

Modifications:

Change signature to make it possible to detect if success or not.

Result:

Fix implementation

@normanmaurer normanmaurer requested a review from a team as a code owner November 27, 2023 14:50
quiche/include/quiche.h Outdated Show resolved Hide resolved
@normanmaurer normanmaurer force-pushed the quiche_conn_new_scid_fix branch 2 times, most recently from 1fdf88d to b47e858 Compare November 27, 2023 14:55
Motivation:

The implementation of quiche_conn_new_scid(...) made it impossible to know if the call was a success or not as even on a sucessfull call it might return a negative value.

Modifications:

Change signature to make it possible to detect if success or not.

Result:

Fix implementation
@normanmaurer normanmaurer force-pushed the quiche_conn_new_scid_fix branch from b47e858 to d29990c Compare November 27, 2023 15:03
@ghedo ghedo merged commit 1a92311 into cloudflare:master Nov 27, 2023
24 checks passed
@normanmaurer normanmaurer deleted the quiche_conn_new_scid_fix branch December 8, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants