Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Testing Golden Snapshots #939

Merged
merged 34 commits into from
Jan 18, 2025
Merged

Add Support for Testing Golden Snapshots #939

merged 34 commits into from
Jan 18, 2025

Conversation

osterman
Copy link
Member

@osterman osterman commented Jan 14, 2025 •
edited
Loading

what

  • Genereate snapshots locally & commit them with the -regenerate-snapshots argument
  • Test for changes by comparison golden snapshots with output
  • Support TTY emulation (pty)
  • Add support for !not tag to negate conditions
  • Add a JSON schema for the test cases (to avoid silent failures)

why

  • Too hard to add thorough tests for command line invocations

@osterman osterman requested a review from a team as a code owner January 14, 2025 19:36
@osterman osterman added the no-release Do not create a new release (wait for additional code changes) label Jan 14, 2025
@mergify Mergify
Copy link

mergify bot commented Jan 14, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Jan 14, 2025
@osterman osterman requested a review from a team as a code owner January 16, 2025 16:01
@mergify Mergify
Copy link

mergify bot commented Jan 17, 2025

💥 This pull request now has conflicts. Could you fix it @osterman? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Jan 17, 2025
@mergify mergify bot removed the conflict This PR has conflicts label Jan 17, 2025
aknysh
aknysh approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aknysh aknysh merged commit e98c3aa into main Jan 18, 2025
44 checks passed
@aknysh aknysh deleted the snapshotting branch January 18, 2025 03:16
@mergify mergify bot removed the needs-cloudposse Needs Cloud Posse assistance label Jan 18, 2025
@github-actions GitHub Actions
Copy link

These changes were released in v1.151.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtholiya samtholiya samtholiya left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osterman @aknysh @samtholiya