feat: Enable GitHub visual tests #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubencarvalho
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 9 9
Lines 63 63
Branches 17 17
=====================================
Misses 56 56
Partials 7 7 ☔ View full report in Codecov by Sentry. |
rubencarvalho
force-pushed
the
enable-github-visual-tests
branch
from
c78ed42 to
04b82b4
Compare
rubencarvalho
force-pushed
the
enable-github-visual-tests
branch
from
04b82b4 to
c4597b7
Compare
rubencarvalho
requested review from
taheramr,
timogasda and
pan-kot
and removed request for
a team
timogasda
reviewed
Jan 25, 2024
| @@ -0,0 +1,60 @@ | |||
| name: Visual Regressions | |||
There was a problem hiding this comment.
Should we move this to a reusable workflow in https://github.com/cloudscape-design/actions?
There was a problem hiding this comment.
I've added the shared workflow
rubencarvalho
force-pushed
the
enable-github-visual-tests
branch
from
42553c0 to
c4597b7
Compare
timogasda
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling visual regression tests.
This initial run will fail, as the update task will only run once merged in main.
Related PR: cloudscape-design/actions#12
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.