-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Elasticsearch Emitter to index Frames into an ElasticSearch Index #395
base: master
Are you sure you want to change the base?
Added Elasticsearch Emitter to index Frames into an ElasticSearch Index #395
Conversation
Signed-off-by: Mahesh Babu Gorantla <[email protected]>
requirements.txt
Outdated
python-dateutil==2.4.2 | ||
semantic_version==2.5.0 | ||
Yapsy==1.11.223 | ||
backports.ssl-match-hostname==3.7.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plugin-specific dependencies should not be added to the global list, but installed inside the plugin itself.
Think about the case where one isn't using the emitter but yet ends up installing all the unnecessary packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahilsuneja1 Okay I made the change suggested and rolled back the global list of packages in requirements.txt
file.
Test environment setup failing. Maybe need to update |
Signed-off-by: Mahesh Babu Gorantla <[email protected]>
Signed-off-by: Mahesh Babu Gorantla <[email protected]>
I tried updating test environment setup but failed (#396). Error: |
ElasticSearch Emitter
Resolves Issue #392
Summary of Changes
Elasticsearch Emitter
UnitTest
to test formatting of crawler frames into elasticsearch document formatResults
Environment Setup
Crawling and Indexing frames in INVM Crawl Mode
Kibana Query (Filtering by extraMetadata fields)
hostname : "my_ubuntu_1804" and iteration_number : "1"
hostname : "my_ubuntu_1804" and iteration_number : "2"