Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vs using sitemap.xml fork branch #389

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

vs using sitemap.xml fork branch #389

wants to merge 5 commits into from

Conversation

MBcode
Copy link
Contributor

@MBcode MBcode commented Oct 14, 2022

Description

Review Time Estimate

  • Immediately
  • Within one week
  • [ x] When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • [ x] I have updated the CHANGELOG.md.
  • I have signed the CLA
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MBcode MBcode mentioned this pull request Oct 14, 2022
Open
@MBcode MBcode requested a review from robkooper October 14, 2022 15:54
@MBcode
Copy link
Contributor Author

MBcode commented Oct 14, 2022 •
edited
Loading

add-sitemap-route branch for issue351 A test has been up through all the versions so far

MBcode added 3 commits October 21, 2022 10:50
@MBcode
Update Application.scala
735b0b1 
getDatasets for User.anonymous for now, vs using the route
can look at possible caching and changing list limit in next iteration
@MBcode
Update Application.scala
bd9e344 
from remote sitemap.xml branch
@MBcode
Create sitemap.xml
fc1b0e9 
from remote sitemap.xml branch
@MBcode MBcode marked this pull request as ready for review October 28, 2022 14:13
lmarini
lmarini requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@lmarini lmarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we return all datasets, including private ones. I think we should only return public ones. We are calling TreeService.getDatasets() which returns datasets Permission.ViewDataset. We should probably just return public datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robkooper robkooper robkooper left review comments

@lmarini lmarini lmarini requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MBcode @lmarini @robkooper