Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for nhsn doc #1581

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Hotfix for nhsn doc #1581

wants to merge 3 commits into from

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jan 24, 2025

addresses #1579

Summary:

New NHSN doc page was titled with NSSP info.

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@nmdefries nmdefries requested a review from aysim319 January 24, 2025 23:49
@nmdefries
Copy link
Contributor Author

Maybe this is considered a hotfix and should be merged directly to main?

aysim319
aysim319 previously approved these changes Jan 26, 2025
@aysim319 aysim319 requested review from carlynvandyke and removed request for carlynvandyke January 27, 2025 16:24
@aysim319 aysim319 changed the title New title for NHSN page Hotfix for nhsn doc Jan 27, 2025
@aysim319 aysim319 linked an issue Jan 27, 2025 that may be closed by this pull request
@aysim319 aysim319 changed the base branch from dev to main January 27, 2025 16:42
@carlynvandyke
Copy link

The name in the Data Sources and Signals menu is also wrong- can we change from "NHSN ED Visits" to "NHSN Hospital Respiratory Data" before merging?

@@ -1,10 +1,10 @@
---
title: NHSN ED Visits
title: NHSN Respiratory Hospitalizations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name in the Data Sources and Signals menu is also wrong- can we change from "NHSN ED Visits" to "NHSN Hospital Respiratory Data" before merging?

this should be the code that gets templated and get reflected in the docs, but I'm also loading the local run and checking if that's the case @carlynvandyke

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that update after I commented- looks fine to me!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-27 at 2 00 56 PM
took a while, but verified that it's NHSN Respiratory Hospitalizations

Copy link

@carlynvandyke carlynvandyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NHSN documentation needs cleaning
4 participants