Requirements.txt: Add it #27
Conversation
RohanVB
force-pushed
the
reqbranch
branch
7 times, most recently
from
7168a2d to
9ae5724
Compare
requirements.txt
Outdated
| @@ -0,0 +1 @@ | |||
| coala_bears>=0.1.0.dev20160303173809 | |||
There was a problem hiding this comment.
seriously? Can you upgrade that to 0.10? ;)
| @@ -0,0 +1 @@ | |||
| coala_bears>=0.10.0 | |||
There was a problem hiding this comment.
I think we Prefer new line at EOF not sure though
There was a problem hiding this comment.
@RohanVB review history showed that you went for some dev version of coala-bears, so I assume there might've been some reason for opting for that one. If it is, consider it a gentle reminder, if it is not, ignore ;)
There was a problem hiding this comment.
@meetmangukiya That was from: https://github.com/coala/coala-sublime/pull/19/files actually. I didn't check the version when I made the PR. I'm not sure what you mean - gentle reminder for? I don't mind the comment made :p
|
Change commit to |
|
why circle if we don't test? |
|
@Mixih that's what the cohesive editor support project tends to achieve :D |
|
ah, so just setting things up for the future? can we separate into a separate commit then please? |
There was a problem hiding this comment.
The repository has tests, and they are not being run on Circle CI, so the circle.yml has an error as that is what it is supposed to do.
Otherwise we end up with people believing that the tests are all running, and new tests are added but broken. That is what happened with https://gitlab.com/coala/package_manager/issues/39 , and took an enormous effort to fix the mess.
So please either remove the circle.yml commit, or fix it. It should only require two additional lines.
|
Closing because the plugin sucks and I'll be doing #36 anyways. |
Closes: #17