-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bare-Butt CLI Fix #69
base: master
Are you sure you want to change the base?
Conversation
* ignore VS Code workspace settings * refactored compile (tsconfig, src/) * fix(build) refactored build scripts & typings * finished build refactoring, verified on other proj * cleared TODO item * removed donation link for now
This reverts commit 146608b.
Requires package to be imported as "angular2-logger" instead of "angular2-logger/core"
Is it possible to do this while keeping |
Mmmm yes... But it requires the changes to the project layout that I did in the fork. We don't have to rename app to src, but the basic folder structure is specifically for the submodule behavior. |
It creates a lot of folder clutter, and I imagine bundling's going to be a nightmare because each submodule would need its own bundle... Plus the user would have to know the name of each module's url. If the project is organized into NgModule classes, the user just has to remember the root directory. Intellisense can list all the NgModule classes referenced from the root Edit: And come to think of it, I don't see how the es5 bundles would work automatically with multiple entry points. |
By the way, I don't think my opinions are better. I'm fallible and I'm wrong all the time. I only know a bit about front-end development, and anything I say is based off my preferences. I don't care what design decisions you choose. I just like solving puzzles when I can, so I might help. |
Simplest fix possible for the angular-cli issue #65. However, this is a breaking change that requires the api to be imported from
angular2-logger
instead ofangular2-logger/core
.All it does is point es6 compatible tools at the
dist/es6/core.js
entry point as if it was anindex.js
in the root folder, and let's ts findcore.d.ts
as if it wereindex.d.ts
.Note: GitHub should give you the option to squash this into one commit. If it doesn't, let me know and I'll do it.