feat: Add bundle cache modal to bundles tab #3653

nicholas-codecov · 2025-01-13T18:38:29Z

Description

Note

~~This PR requires #3652 before reviewing/merging~~

This PR adds in a button to the bundles tab that toggles the newly bundle caching modal, that is hidden behind a feature flag.

Ticket: codecov/engineering-team#3157

Notable Changes

Add in button and modal to BundleSelection component
Add in new tests

Screenshots

codecov · 2025-01-13T18:41:12Z

Bundle Report

Changes will increase total bundle size by 2.51kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	6.05MB	1.33kB (0.02%) ⬆️
gazebo-production-esm	6.1MB	1.18kB (0.02%) ⬆️

codecov-notifications · 2025-01-13T18:41:53Z

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../BundleContent/BundleSelection/BundleSelection.tsx	80.00%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
- Coverage   98.93%   98.93%   -0.01%     
==========================================
  Files         815      815              
  Lines       14681    14686       +5     
  Branches     4158     4160       +2     
==========================================
+ Hits        14525    14529       +4     
- Misses        149      150       +1     
  Partials        7        7

Files with missing lines	Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx	`100.00% <ø> (ø)`
.../BundleContent/BundleSelection/BundleSelection.tsx	`94.11% <80.00%> (-5.89%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.62% <80.00%> (-0.02%)`	⬇️
Services	`99.34% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d8acb...6510c26. Read the comment docs.

codecov-public-qa · 2025-01-13T18:41:57Z

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.93%. Comparing base (12d8acb) to head (6510c26).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../BundleContent/BundleSelection/BundleSelection.tsx	80.00%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
- Coverage   98.93%   98.93%   -0.01%     
==========================================
  Files         815      815              
  Lines       14681    14686       +5     
  Branches     4158     4168      +10     
==========================================
+ Hits        14525    14529       +4     
- Misses        149      150       +1     
  Partials        7        7

Files with missing lines	Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx	`100.00% <ø> (ø)`
.../BundleContent/BundleSelection/BundleSelection.tsx	`94.11% <80.00%> (-5.89%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.62% <80.00%> (-0.02%)`	⬇️
Services	`99.34% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d8acb...6510c26. Read the comment docs.

codecov-qa · 2025-01-13T18:42:00Z

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.93%. Comparing base (12d8acb) to head (6510c26).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../BundleContent/BundleSelection/BundleSelection.tsx	80.00%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
- Coverage   98.93%   98.93%   -0.01%     
==========================================
  Files         815      815              
  Lines       14681    14686       +5     
  Branches     4158     4168      +10     
==========================================
+ Hits        14525    14529       +4     
- Misses        149      150       +1     
  Partials        7        7

Files with missing lines	Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx	`100.00% <ø> (ø)`
.../BundleContent/BundleSelection/BundleSelection.tsx	`94.11% <80.00%> (-5.89%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.62% <80.00%> (-0.02%)`	⬇️
Services	`99.34% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d8acb...6510c26. Read the comment docs.

codecov · 2025-01-13T18:42:00Z

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.93%. Comparing base (12d8acb) to head (6510c26).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../BundleContent/BundleSelection/BundleSelection.tsx	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
- Coverage   98.93%   98.93%   -0.01%     
==========================================
  Files         815      815              
  Lines       14681    14686       +5     
  Branches     4166     4160       -6     
==========================================
+ Hits        14525    14529       +4     
- Misses        149      150       +1     
  Partials        7        7

Files with missing lines	Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx	`100.00% <ø> (ø)`
.../BundleContent/BundleSelection/BundleSelection.tsx	`94.11% <80.00%> (-5.89%)`	⬇️

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.62% <80.00%> (-0.02%)`	⬇️
Services	`99.34% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d8acb...6510c26. Read the comment docs.

codecov-releaser · 2025-01-13T18:43:56Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`95fd2f4`	Mon, 13 Jan 2025 18:43:55 GMT	Expired	Expired
`12f72a0`	Mon, 13 Jan 2025 18:58:18 GMT	Expired	Expired
`a5490a4`	Tue, 14 Jan 2025 19:40:54 GMT	Expired	Expired
`604d1f7`	Wed, 15 Jan 2025 12:09:41 GMT	Expired	Expired
`6510c26`	Wed, 15 Jan 2025 12:21:27 GMT	Cloud	Enterprise

codecov-staging · 2025-01-13T18:54:53Z

Bundle Report

Changes will increase total bundle size by 6.1MB (100.65%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
gazebo-staging-esm	6.1MB	6.1MB (100%) ⬆️⚠️

src/pages/RepoPage/shared/ConfigureCachedBundleModal/ConfigureCachedBundleModal.tsx

calvin-codecov

1 copy suggestion. Looking good!

…undles-tab

nicholas-codecov changed the title ~~Gh eng 3157 feat add bundle cache modal to bundles tab~~ feat: Add bundle cache modal to bundles tab Jan 13, 2025

nicholas-codecov added 9 commits January 14, 2025 15:32

add in modal to control bundle cache settings

8f30ebb

add in tests for new modal

4184133

remove use of context as we can just use normal react state

e1260b5

update comments

2ac2f60

tidy up isPending

6645fa9

move bundle cache modal to repo page shared directory

d623939

add modal to bundle selection component

d098062

add in new tests

61a4069

make font semibold

a5490a4

nicholas-codecov force-pushed the gh-eng-3157-feat-add-bundle-cache-modal-to-bundles-tab branch from 12f72a0 to a5490a4 Compare January 14, 2025 19:34

calvin-codecov reviewed Jan 14, 2025

View reviewed changes

src/pages/RepoPage/shared/ConfigureCachedBundleModal/ConfigureCachedBundleModal.tsx Outdated Show resolved Hide resolved

calvin-codecov approved these changes Jan 14, 2025

View reviewed changes

nicholas-codecov added 2 commits January 15, 2025 08:04

small copy tweak

604d1f7

Merge branch 'main' into gh-eng-3157-feat-add-bundle-cache-modal-to-b…

6510c26

…undles-tab

nicholas-codecov added this pull request to the merge queue Jan 15, 2025

Merged via the queue into main with commit a916ed4 Jan 15, 2025
50 of 62 checks passed

nicholas-codecov deleted the gh-eng-3157-feat-add-bundle-cache-modal-to-bundles-tab branch January 15, 2025 12:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add bundle cache modal to bundles tab #3653

feat: Add bundle cache modal to bundles tab #3653

nicholas-codecov commented Jan 13, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading

codecov-notifications bot commented Jan 13, 2025 •

edited

Loading

codecov-public-qa bot commented Jan 13, 2025 •

edited

Loading

codecov-qa bot commented Jan 13, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading

codecov-releaser commented Jan 13, 2025 •

edited

Loading

codecov-staging bot commented Jan 13, 2025 •

edited

Loading

calvin-codecov left a comment

feat: Add bundle cache modal to bundles tab #3653

feat: Add bundle cache modal to bundles tab #3653

Conversation

nicholas-codecov commented Jan 13, 2025 • edited Loading

Description

Notable Changes

Screenshots

codecov bot commented Jan 13, 2025 • edited Loading

Bundle Report

codecov-notifications bot commented Jan 13, 2025 • edited Loading

Codecov Report

codecov-public-qa bot commented Jan 13, 2025 • edited Loading

Codecov Report

codecov-qa bot commented Jan 13, 2025 • edited Loading

Codecov Report

codecov bot commented Jan 13, 2025 • edited Loading

Codecov Report

codecov-releaser commented Jan 13, 2025 • edited Loading

✅ Deploy preview for gazebo ready!

codecov-staging bot commented Jan 13, 2025 • edited Loading

Bundle Report

calvin-codecov left a comment

Choose a reason for hiding this comment

nicholas-codecov commented Jan 13, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading

codecov-notifications bot commented Jan 13, 2025 •

edited

Loading

codecov-public-qa bot commented Jan 13, 2025 •

edited

Loading

codecov-qa bot commented Jan 13, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading

codecov-releaser commented Jan 13, 2025 •

edited

Loading

codecov-staging bot commented Jan 13, 2025 •

edited

Loading