Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Infer name if not in billing details #3676

Merged
merged 5 commits into from
Jan 22, 2025
Merged

fix: Infer name if not in billing details #3676

merged 5 commits into from
Jan 22, 2025

Conversation

suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Jan 22, 2025 •
edited
Loading

It appears some customers can have messy data missing billing details email or name, which makes them encounter an error on the Payment Element (this UI element requires this that was formerly optional with the Card Element).
Instead infer these values from other places on the Stripe customer such as the name/email on the latest invoice, or that attached to the customer, or that attached to the accountDetails.

Fixes https://codecov.sentry.io/issues/6237642048/?alert_rule_id=15115849&alert_type=issue&notification_uuid=50a22e19-57b2-4b3e-81c9-c85911f30570&project=5514400&referrer=issue_alert-slack

@codecov-staging
Copy link

codecov-staging bot commented Jan 22, 2025 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3676   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         825      825           
  Lines       14875    14892   +17     
  Branches     4226     4233    +7     
=======================================
+ Hits        14699    14716   +17     
  Misses        167      167           
  Partials        9        9
Files with missing lines Coverage Δ
...s/CurrentOrgPlan/BillingDetails/BillingDetails.tsx 100.00% <ø> (ø)
...OrgPlan/BillingDetails/PaymentCard/PaymentCard.jsx 100.00% <100.00%> (ø)
...n/BillingDetails/PaymentCard/PaymentMethodForm.tsx 93.61% <100.00%> (+3.29%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.43% <100.00%> (+<0.01%) ⬆️
Services 99.30% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5dcca4...0f4c975. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (a5dcca4) to head (0f4c975).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3676   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         825      825           
  Lines       14875    14892   +17     
  Branches     4234     4233    -1     
=======================================
+ Hits        14699    14716   +17     
  Misses        167      167           
  Partials        9        9
Files with missing lines Coverage Δ
...s/CurrentOrgPlan/BillingDetails/BillingDetails.tsx 100.00% <ø> (ø)
...OrgPlan/BillingDetails/PaymentCard/PaymentCard.jsx 100.00% <100.00%> (ø)
...n/BillingDetails/PaymentCard/PaymentMethodForm.tsx 93.61% <100.00%> (+3.29%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.43% <100.00%> (+<0.01%) ⬆️
Services 99.30% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5dcca4...0f4c975. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (a5dcca4) to head (0f4c975).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3676   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         825      825           
  Lines       14875    14892   +17     
  Branches     4226     4233    +7     
=======================================
+ Hits        14699    14716   +17     
  Misses        167      167           
  Partials        9        9
Files with missing lines Coverage Δ
...s/CurrentOrgPlan/BillingDetails/BillingDetails.tsx 100.00% <ø> (ø)
...OrgPlan/BillingDetails/PaymentCard/PaymentCard.jsx 100.00% <100.00%> (ø)
...n/BillingDetails/PaymentCard/PaymentMethodForm.tsx 93.61% <100.00%> (+3.29%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.43% <100.00%> (+<0.01%) ⬆️
Services 99.30% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5dcca4...0f4c975. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.11kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.19MB 365 bytes (0.01%) ⬆️
gazebo-production-esm 6.24MB 745 bytes (0.01%) ⬆️

@suejung-sentry suejung-sentry marked this pull request as ready for review January 22, 2025 17:51
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 22, 2025 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
ebdd740 Wed, 22 Jan 2025 17:54:06 GMT Expired Expired
d6afd68 Wed, 22 Jan 2025 18:04:08 GMT Expired Expired
2407564 Wed, 22 Jan 2025 18:30:14 GMT Expired Expired
0f4c975 Wed, 22 Jan 2025 18:37:33 GMT Cloud Enterprise

@codecov Codecov
Copy link

codecov bot commented Jan 22, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (a5dcca4) to head (0f4c975).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3676   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         825      825           
  Lines       14875    14892   +17     
  Branches     4234     4241    +7     
=======================================
+ Hits        14699    14716   +17     
  Misses        167      167           
  Partials        9        9
Files with missing lines Coverage Δ
...s/CurrentOrgPlan/BillingDetails/BillingDetails.tsx 100.00% <ø> (ø)
...OrgPlan/BillingDetails/PaymentCard/PaymentCard.jsx 100.00% <100.00%> (ø)
...n/BillingDetails/PaymentCard/PaymentMethodForm.tsx 93.61% <100.00%> (+3.29%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.43% <100.00%> (+<0.01%) ⬆️
Services 99.30% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5dcca4...0f4c975. Read the comment docs.

ajay-sentry
ajay-sentry approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@suejung-sentry suejung-sentry added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit b7ce614 Jan 22, 2025
62 checks passed
@suejung-sentry suejung-sentry deleted the sshin/fix-name branch January 22, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suejung-sentry @codecov-releaser @ajay-sentry