fix: Hide tokenless banner for signed out user #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 75 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3677 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 825
Lines 14892 14893 +1
Branches 4233 4233
=======================================
+ Hits 14716 14717 +1
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3677 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 825
Lines 14892 14893 +1
Branches 4233 4241 +8
=======================================
+ Hits 14716 14717 +1
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3677 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 825
Lines 14892 14893 +1
Branches 4241 4241
=======================================
+ Hits 14716 14717 +1
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3677 +/- ##
=======================================
Coverage 98.81% 98.81%
=======================================
Files 825 825
Lines 14892 14893 +1
Branches 4233 4233
=======================================
+ Hits 14716 14717 +1
Misses 167 167
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
calvin-codecov
force-pushed
the
cy/no_tokenless_banner_signed_out
branch
from
470b463 to
ef1d10b
Compare
Bundle ReportChanges will increase total bundle size by 75 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes codecov/engineering-team#3009
Code Example
Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.