-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bill follow and unfollow functionality to testimony page #1661
Merged
Mephistic
merged 6 commits into
codeforboston:main
from
aaerhart:bill-un-follow-functionality-testimony-detail-page
Jan 21, 2025
Merged
feat: bill follow and unfollow functionality to testimony page #1661
Mephistic
merged 6 commits into
codeforboston:main
from
aaerhart:bill-un-follow-functionality-testimony-detail-page
Jan 21, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaerhart
requested review from
sashamaryl,
mertbagt,
nesanders,
mvictor55,
timblais,
alexjball,
Mephistic and
kiminkim724
as code owners
December 17, 2024 22:50
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kiminkim724
reviewed
Dec 18, 2024
kiminkim724
reviewed
Dec 18, 2024
kiminkim724
reviewed
Dec 18, 2024
components/testimony/TestimonyDetailPage/TestimonyDetailPage.tsx
Outdated
Show resolved
Hide resolved
…ttps://github.com/aaerhart/maple into bill-un-follow-functionality-testimony-detail-page
Mephistic
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a couple of nits. Thanks for taking this on!
Mephistic
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1652 A functional click event with a request and resposne has been added to the Follow bill button in the menu on the Testimony Detail page for each testimony.
Checklist
Screenshots
Known issues
Steps to test/reproduce