Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
jfahrer committed Dec 2, 2023
1 parent 80cdbd8 commit 025dd2c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@

## DeploymentConfig

- Content is not rendering correctly (need to read file instead of passing filename)
- Directory is there twice
- Mount configs
- Don't upload configs if they already exist
- Use `service` instead of `deployment` for config generation
- Make `config` part of a `deployment`
- Make `config` part of a `deployment`?
- Tests should go through the whole flow and actually upload something

## Bugs

- containers_to_replace includes containers_to_start if the container already exists
- If the container count changes, it is mixing up stopping with replacing
- Changing order of role/service definitions should not change the version

Expand Down
12 changes: 6 additions & 6 deletions lib/cove/host.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
module Cove
class Host
# @return [String]
attr_reader :name, :user
attr_reader :name
# @return [String]
attr_reader :user
# @return [String]
attr_reader :sshkit_host

# @param [String] name
# @param [String] hostname
Expand All @@ -10,18 +14,14 @@ def initialize(name:, hostname: nil, user: nil)
@name = name
@hostname = hostname
@user = user
@sshkit_host ||= SSHKit::Host.new(ssh_destination_string)
end

# @return [String]
def id
name
end

# @return [SSHKit::Host]
def sshkit_host
@sshkit_host ||= SSHKit::Host.new(ssh_destination_string)
end

# @return [String]
def ssh_destination_string
[user, hostname].compact.join("@")
Expand Down

0 comments on commit 025dd2c

Please sign in to comment.