do not try connecting if there are incomplete credentials, fixed #42

codmpm · Feb 7, 2020 · 4a0d29c · 4a0d29c
1 parent 2ad9c22
commit 4a0d29c
Show file tree

Hide file tree

Showing 2 changed files with 120 additions and 114 deletions.
diff --git a/loxone/loxone.js b/loxone/loxone.js
@@ -143,6 +143,12 @@ module.exports = function (RED) {
             node.encMethod = encMethods[config.enctype];
         }
 
+        if (!node.credentials.username || !node.credentials.password) {
+            node.error("missing credentials for " + config.host + ':' + config.port);
+            return;
+
+        }
+
         let client = new node_lox_ws_api(
             config.host + ':' + config.port,
             node.credentials.username,
@@ -153,6 +159,7 @@ module.exports = function (RED) {
 
         client.connect();
 
+
         client.on('connect', function () {
             node.log('Miniserver connected (' + config.host + ':' + config.port + ') using ' + node.encMethod);
         });
@@ -245,7 +252,7 @@ module.exports = function (RED) {
                             }
 
                             //add miniserver info
-                            if(node.structureData) {
+                            if (node.structureData) {
                                 msg.msInfo = node.structureData.msInfo;
                                 msg.lastModified = node.structureData.lastModified;
                             } else {

diff --git a/package-lock.json b/package-lock.json