Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sample scripts using V2 Client #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added sample scripts using V2 Client #3

wants to merge 1 commit into from

Conversation

naveena-maplelabs
Copy link
Contributor

  1. Added python script to register vmware source, create a protection job, trigger a run and delete the job.
  2. Added script to register a view and create a job using the view.

@naveena-maplelabs naveena-maplelabs self-assigned this Feb 1, 2024
pyashish
pyashish reviewed Feb 4, 2024
View reviewed changes
samples/helios/helios_client.py Outdated
@@ -0,0 +1,57 @@
import pytest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the pytest part

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

pyashish
pyashish reviewed Feb 4, 2024
View reviewed changes
samples/helios/vmware_workflow_using_v2.py Outdated


def get_objects_by_vmname():
vm_size = 99999999999
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this logic this way ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To find a VM of smaller size

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment with the size of the VM defined, also this could be constant upfront , for users to change the value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

@github-actions github-actions bot requested review from pyashish February 5, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyashish pyashish Awaiting requested review from pyashish

Assignees

@naveena-maplelabs naveena-maplelabs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naveena-maplelabs @pyashish