change required fields to optional in physical cluster resource #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyashish
reviewed
Sep 23, 2021
| IpmiSubnetMask: &ipmiSubnetMask, | ||
| IpmiUsername: &ipmiUsername, | ||
| ipmiConfig := models.IpmiConfiguration{} | ||
| if ipmiGateway != "" { |
There was a problem hiding this comment.
We need to handle a case where users passes this as null object ?
There was a problem hiding this comment.
when no value is assigned for string variable, it takes empty string by default, this is handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synced up with Sudeep to check the required fields in physical cluster creation, in the latest releases they made certain fields from required to optional, since these are backward compatible changes - made these changes in our terraform privider.