Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @Module syntax support for V4 #158

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mrigsby
Copy link
Contributor

@mrigsby mrigsby commented Jun 20, 2024

Added @Module syntax support back for Version 4. Enables wires to be located in a module and run from anywhere in your application.

Example:

#wire( "myWire@myModule" )#

CBWire will translate the wire path to:

/modules_app/myModule/wires/myWire

Copy link
Collaborator

@grantcopley grantcopley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great work!

@grantcopley grantcopley merged commit edd350a into coldbox-modules:development Jun 21, 2024
3 of 4 checks passed
@mrigsby
Copy link
Contributor Author

mrigsby commented Jun 21, 2024

Thanks! I have another minor change I will submit a pull request for here shortly to fix an error I was getting when I have a data property that is a struct and not a string or array.

@mrigsby mrigsby deleted the addV4ModuleSupport branch June 21, 2024 15:18
@grantcopley
Copy link
Collaborator

@mrigsby Deployed with patch v4.0.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants