-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable manual sorting of selected taxonomy items #74
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks much better to me
@malthe maybe you can take a look at this? |
I'm not sure I understand the solution here. It seems like all the code just deleted. Either a clear analysis of the change should be presented, or a test case that shows the issue and how it's fixed with this change. It's been a while since I touched this code so it's hard for me to understand the correctness of it. |
@malthe yes you're right and I'm sorry for this code cut. The problem is, I cannot clearly reproduce the strange behavior of miss-ordered taxonomies. but it happens ... and with this simpler code it doesn't happen again. maybe it's because of python3 ... need to make some more investigations. |
@petschki should we merge this or is there anything more to do? |
There is a confusing ordering problem in a project of @agitator and me and this PR tries to fix it but AFAIK there are still some edge cases ... so not ready to merge for now |
c99781f
to
1ae4952
Compare
fixes #71