contributing.md instructions for creating tests #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fayti1703
requested changes
Jan 16, 2024
Comment on lines
+43
to
+46
| expect(log2(0)).toThrow(); | ||
| expect(log2(-1)).toThrow(); |
There was a problem hiding this comment.
This doesn't catch the throw unless you wrap the code to test in a function:
Suggested change
| expect(log2(0)).toThrow(); | |
| expect(log2(-1)).toThrow(); | |
| expect(() => log2(0)).toThrow(); | |
| expect(() => log2(-1)).toThrow(); |
(I know this is just example code, but still.)
seanmakesgames
force-pushed
the
tukib/creating-tests
branch
from
11d630d to
1220a85
Compare
|
@Fayti1703 @oolu4236 @ellipsisasterisk and I checked this out on codespaces and also updated the branch to remove conflicts. The changes to the jest config file did not break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
friendlier instructions for creating tests, with links to Jest documentation.