-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config clean command sketch #17514
base: develop2
Are you sure you want to change the base?
Config clean command sketch #17514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good idea, and necessary, thanks very much for doing it!
Maybe reset
is a better name if the intent is to reset to "factory defaults"? I am fine with either name, just nitpicking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
|
||
def reinit(self): | ||
self.config.reinit() | ||
self.config.migrate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this migrate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, forcing a new migration should probably be explicit too.
validate_conan_version(required_range_new) | ||
_check_conan_version(self) | ||
|
||
def reinit(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open to better names!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specially opposed to reinit
, other possible alternatives
- reset
- restart
- invalidate_cache
Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
To discuss with the team
Addresses the remaining point of #12842
Close #5935
Close #12842