Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS name in test matrix for AzureSignTool installation #792

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix OS name in test matrix for AzureSignTool installation #792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f628091
Fix OS name in test matrix for AzureSignTool installation
marcoesters May 8, 2024
0ecc142
Correct PR number in news
marcoesters May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
environment-file: dev/environment.yml
python-version: ${{ matrix.python-version }}
- name: Install AzureSignTool
if: matrix.os == 'windows'
if: startswith(matrix.os, 'windows')
run: dotnet.exe tool install --global AzureSignTool
shell: pwsh
- name: Supply extra dependencies and install constructor
Expand Down
1 change: 1 addition & 0 deletions docs/source/howto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ For each tool, there are environment variables that may need to be set to config

If neither `AZURE_SIGNTOOL_KEY_VAULT_ACCESSTOKEN` nor `AZURE_SIGNTOOL_KEY_VAULT_SECRET` are set, `constructor` will use a Managed Identity (`-kvm` CLI option).
:::

### Signing and notarizing PKG installers

In the case of macOS, users might get warnings for PKGs if the installers are not signed _and_ notarized. However, once these two requirements are fulfilled, the warnings disappear instantly.
Expand Down
2 changes: 1 addition & 1 deletion news/771-add-azure-signtool-support
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### Enhancements

* Add support for AzureSignTool to sign Windows installers. (#767 via #771)
* Add support for AzureSignTool to sign Windows installers. (#767 via #771 and #792)

### Bug fixes

Expand Down
Loading