Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find libc.so directly in musl systems #856

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Sep 11, 2024

Description

Closes ##850

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Sep 11, 2024
@jaimergp jaimergp marked this pull request as ready for review September 11, 2024 15:44
@jaimergp jaimergp requested a review from a team as a code owner September 11, 2024 15:44
Co-authored-by: drewgilliam <[email protected]>
libc_so="$(find /lib /usr/local/lib /usr/lib -name 'libc.so.*' -print -quit 2>/dev/null)"
if [ -z "${libc_so}" ]; then
libc_so="$(strings /etc/ld.so.cache | grep '^/.*/libc\.so.*' | head -1)"
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be another conditional here in case libc_so is still empty after this to error out or emit a warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@jaimergp jaimergp merged commit f4b3bfd into conda:main Sep 13, 2024
18 checks passed
@jaimergp jaimergp mentioned this pull request Sep 13, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants