Fix some issues with virtual_specs
#887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
This was referenced Nov 8, 2024
marcoesters
reviewed
Nov 8, 2024
| CONDA_SOLVER="classic" \ | ||
| CONDA_PKGS_DIRS="$(mktemp -d)" \ | ||
| SYSTEM_VERSION_COMPAT=0 \ |
There was a problem hiding this comment.
Since checking for the virtual package is removed, I don't think this variable is needed anymore.
There was a problem hiding this comment.
It doesn't hurt either I guess?
| @@ -479,7 +479,7 @@ mkdir -p "$TMP" | |||
| # but we haven't created $PREFIX/pkgs yet... give it a temp location | |||
| # shellcheck disable=SC2050 | |||
| if [ "__VIRTUAL_SPECS__" != "" ]; then | |||
| echo 'Checking virtual specs compatibility: __VIRTUAL_SPECS__' | |||
| echo "Checking virtual specs compatibility:" __VIRTUAL_SPECS__ | |||
There was a problem hiding this comment.
Suggested change
| echo "Checking virtual specs compatibility:" __VIRTUAL_SPECS__ | |
| echo "Checking virtual specs compatibility: __VIRTUAL_SPECS__" |
The new code looks like it would render as "compatibility:'__virtual'". I think just replacing the single quotes with double quotes will be fine.
There was a problem hiding this comment.
__VIRTUAL_SPECS__ is shlex.join'ed so it will contain single quotes if it has > in it. But I'm not sure what will happen if the user types "__osx>=10.13". Given that echo admits several parameters, I'm inclined to let it roam freely because it's supposed to work like that.
marcoesters
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?