added contributing file #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributing.md
Outdated
| 7. _(Android only):_ Open the expo app and scan the QR code | ||
| 8. TODO: document the simulator step | ||
|
|
||
| [IMG] |
There was a problem hiding this comment.
What image is shown here?
contributing.md
Outdated
| 5. Run `npm start` to start the development process | ||
| 6. _(IPhone only):_ Open the camera and scan the QR code | ||
| 7. _(Android only):_ Open the expo app and scan the QR code | ||
| 8. TODO: document the simulator step |
There was a problem hiding this comment.
TODO's should move into issues.
contributing.md
Outdated
| - note: don't use `name` (or `backgroundColor`, `width`, `height`, `Render`, `Text`, `Image`, `Slice9`) when you name arboarts, because it will conflict with internal variables. [ISSUE#2](https://github.com/consento-org/expo-export/issues/2) | ||
| - After the export you should see updates in the `/styles/` folder. (visible in Sourcetree) | ||
|
|
||
| [IMG] |
martinheidegger
force-pushed
the
master
branch
2 times, most recently
from
11a0368 to
946b06f
Compare
|
I think it would be good to add a mention about avatars: #12 (comment) |
martinheidegger
force-pushed
the
master
branch
from
b650a73 to
5d69f47
Compare
marcchataigner-zz
force-pushed
the
contributing
branch
from
423981c to
54a81cf
Compare
Tannybunny
force-pushed
the
contributing
branch
from
e6bd1b3 to
760fefd
Compare
…eloper guidelines from other projects.
martinheidegger
force-pushed
the
contributing
branch
from
760fefd to
1ca54ce
Compare
martinheidegger
force-pushed
the
contributing
branch
from
12e2423 to
4fa9e27
Compare
|
Hello @marcchataigner It seems you accidentally already added Anyways, I moved the todo's from the contributing file to issues:
like I asked in #17 (comment) Anyways, should be fine now, lets merge it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14