Passt support #56
Open
Passt support #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Hrica <[email protected]>
This seems to catch more problems, such as the u8/i8 mismatch on aarch64 platforms. Signed-off-by: Matej Hrica <[email protected]>
We need #[allow(unused_mut)], to disable warnings on other targets. Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
You could have a trait and uniform interface for the run method, but it isn't necessary for now. It also allows passing more arguments from main. Signed-off-by: Matej Hrica <[email protected]>
Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
force-pushed
the
passt-support
branch
5 times, most recently
from
46bc7c6 to
2755c06
Compare
mtjhrc
force-pushed
the
passt-support
branch
from
2755c06 to
636ea0a
Compare
This required adding another field to the config. This is done by migrating the old config to a newer version. We are backwards compatible on configuration but not forwards compatible (older versions of krunvm will not be able to use the config from this version) If we want forward compatibility, I feel like we need to ditch the confy crate. Signed-off-by: Matej Hrica <[email protected]>
mtjhrc
force-pushed
the
passt-support
branch
from
636ea0a to
5fc42aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.