Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: remove redundant discriminator checks #3495

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wowinter13
Copy link

@wowinter13 wowinter13 commented Jan 16, 2025

Remove the discriminator checks from the load and load_mut methods

Safe

Remove the load_init method completely

Safe

Fixes #3172

Copy link

vercel bot commented Jan 16, 2025

@wowinter13 is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@wowinter13 wowinter13 force-pushed the fix-redundant-discriminator-checks branch from 904b328 to 9d62248 Compare January 16, 2025 18:36
@wowinter13 wowinter13 changed the title WIP: (lang: remove redundant discriminator checks) lang: remove redundant discriminator checks Jan 19, 2025
@wowinter13
Copy link
Author

@acheroncrypto could you please approve tests build? If I understand the flow correctly

Copy link
Collaborator

@acheroncrypto acheroncrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this PR. However, this came up during our v0.31 audit, and we decided to not remove these checks for now due to the risk being too high for the potential benefit.

@wowinter13
Copy link
Author

Screenshot 2025-01-20 at 10 30 52

Skeletor will be back with new PRs next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant discriminator checks in AccountLoader::load* methods
2 participants