Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Fix the LSM interchaintest for v22. #3469

Closed
wants to merge 2 commits into from
Closed

fix(ci): Fix the LSM interchaintest for v22. #3469

wants to merge 2 commits into from

Conversation

fastfadingviolets
Copy link
Contributor

Description

Some versions of gaia differ in how they report shares vs tokens staked, and that can produce discrepancies in tests. This updates us for a v22 chain, with potential ICAs in v21 chains

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • Confirmed the correct type prefix in the PR title
  • Confirmed all author checklist items have been addressed
  • Confirmed that this PR does not change production code

@fastfadingviolets
fix(ci): Fix the LSM test for v22.
03f6f6f 
Some versions of gaia differ in how they report shares vs tokens staked, and
that can produce discrepancies in tests. This updates us for a v22 chain,
with potential ICAs in v21 chains
MSalopek
MSalopek approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin approval

@fastfadingviolets
Copy link
Contributor Author

https://github.com/cosmos/gaia/actions/runs/12654233904/job/35267595600

@fastfadingviolets fastfadingviolets mentioned this pull request Jan 9, 2025
Merged
8 tasks
@fastfadingviolets fastfadingviolets deleted the interchain/v22-lsm branch January 9, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@dasanchez dasanchez dasanchez approved these changes

@LexaMichaelides LexaMichaelides Awaiting requested review from LexaMichaelides LexaMichaelides is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fastfadingviolets @dasanchez @MSalopek