-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp: use error returns in VerifyMembership fns #7492
Conversation
switch proof.Proofs[0].Proof.(type) { | ||
case *ics23.CommitmentProof_Nonexist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
decided to take the liberty to do some code cleanup. Since proof.Proofs.GetNonexist
only returns a non exist proof, the switch statement is unnecessary since we check the return value is non nil
switch proofs[i].Proof.(type) { | ||
case *ics23.CommitmentProof_Exist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup!
Quality Gate passed for 'ibc-go'Issues Measures |
Description
made this change in relation to cosmos/ics23#391
Example error message now:
Previous error message:
closes: #183
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.