ICS24: Change Provable keys #7517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
requested review from
colin-axner,
damiannolan and
chatton
as code owners
damiannolan
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Bit of a nit but since we're using byte(1), byte(2)..etc, can we list them so they are:
- Commitment
- Ack
- Receipt
rather than the reverse
4 tasks
|
DimitrisJim
approved these changes
Nov 12, 2024
| return []byte(fmt.Sprintf("acks/channels/%s/sequences/%s", channelID, sdk.Uint64ToBigEndian(sequence))) | ||
| // PacketCommitmentKey returns the store key of under which a packet commitment is stored. | ||
| func PacketCommitmentKey(channelID string, sequence uint64) []byte { | ||
| return append(append([]byte(channelID), byte(1)), sdk.Uint64ToBigEndian(sequence)...) | ||
| } | ||
|
|
||
| // PacketCommitmentPrefixKey returns the store key prefix under which packet commitments for a particular channel are stored. | ||
| func PacketCommitmentPrefixKey(channelID string) []byte { |
There was a problem hiding this comment.
though wouldn't this key better belong in channel/v2/types/keys.go? Its only used for iterating through commitments in grpc req?
Currently similar for v1 but maybe a good idea to move. Leaving as is for now.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These keys are less verbose and aligned to be closer together for the same outgoing chain since we key on channelID first rather than the type of packet msg
closes: #7520
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.