Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use address codec #7838

Closed
wants to merge 2 commits into from

Conversation

duvbell
Copy link
Contributor

@duvbell duvbell commented Jan 10, 2025

Description

closes: #7835


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@duvbell duvbell marked this pull request as draft January 10, 2025 16:46
@duvbell
Copy link
Contributor Author

duvbell commented Jan 10, 2025

Hello @gjermundgaraba, i want to address this issue
can you help me check if what im doing is oke, before i do it in other instances?

@gjermundgaraba
Copy link
Contributor

Hello @gjermundgaraba, i want to address this issue can you help me check if what im doing is oke, before i do it in other instances?

Not quite. Let's talk about it in the issue. If there are questions on how to implement it, I want to be able to track that in the issue itself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated usage of AddressFromBech32 with address.Codec
2 participants