Skip to content

Commit

Permalink
fix(ics04): packet receive event type identifier (#1179)
Browse files Browse the repository at this point in the history
* fix: ics04 packet event name

* Add Changelog

* Fix Changelog

* nit on const decl group

* nits on changelog entry

* Add link to ibc-go channel events

---------

Co-authored-by: Ranadeep Biswas <[email protected]>
Co-authored-by: Sean Chen <[email protected]>
  • Loading branch information
3 people authored Apr 22, 2024
1 parent d0f7cc4 commit 41348af
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [ibc-core-channel-types] Make receive packet event type identifier consistent
with `ibc-go`. ([\#1180](https://github.com/cosmos/ibc-rs/issues/1180))
8 changes: 5 additions & 3 deletions ibc-core/ics04-channel/types/src/events/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,20 +25,22 @@ use super::Version;
use crate::error::ChannelError;
use crate::packet::Packet;

/// Channel event types
/// Channel event types corresponding to ibc-go's channel events:
/// https://github.com/cosmos/ibc-go/blob/c4413c5877f9ef883494da1721cb18caaba7f7f5/modules/core/04-channel/types/events.go#L52-L72
const CHANNEL_OPEN_INIT_EVENT: &str = "channel_open_init";
const CHANNEL_OPEN_TRY_EVENT: &str = "channel_open_try";
const CHANNEL_OPEN_ACK_EVENT: &str = "channel_open_ack";
const CHANNEL_OPEN_CONFIRM_EVENT: &str = "channel_open_confirm";
const CHANNEL_CLOSE_INIT_EVENT: &str = "channel_close_init";
const CHANNEL_CLOSE_CONFIRM_EVENT: &str = "channel_close_confirm";
const CHANNEL_CLOSED_EVENT: &str = "channel_close";

/// Packet event types
const SEND_PACKET_EVENT: &str = "send_packet";
const RECEIVE_PACKET_EVENT: &str = "receive_packet";
const RECEIVE_PACKET_EVENT: &str = "recv_packet";
const WRITE_ACK_EVENT: &str = "write_acknowledgement";
const ACK_PACKET_EVENT: &str = "acknowledge_packet";
const TIMEOUT_EVENT: &str = "timeout_packet";
const CHANNEL_CLOSED_EVENT: &str = "channel_close";

#[cfg_attr(
feature = "parity-scale-codec",
Expand Down

0 comments on commit 41348af

Please sign in to comment.