Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize redundant packet checks #1007

Conversation

expertdicer
Copy link

Closes: #817

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@expertdicer expertdicer changed the title prioritize redundant packet checks Prioritize redundant packet checks Dec 13, 2023
@Farhad-Shabani
Copy link
Member

Thank you @expertdicer for bringing up this issue.
I took another look at our checks and current logic and had a lightbulb moment. So, these new moves could boost the parallel relaying setup's performance, but there's a catch. We're kind of assuming that all relayers are on the up-and-up, just forwarding legit packets. But the thing is these changes (as we are placing basic checks afterward) leaves our implementation wide open to potential DOS attacks leaving us w/o having clues of why we are hitting these early no-op returns.
Apologies for that. I'll close the issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Prioritize redundant packet checks for better performance in multi-relayer scenarios
2 participants