feat: derive AsRef for CommitmentProofBytes #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derive AsRef for CommitmentProofBytes so it’s possible to access its underlying bytes without having to own it. The type can be converted into Vec but that requires ownership. If all one has is a reference to the proof bytes (as in verify_membership method for example), there’s no way to access underlying bytes without cloning it first. With derive_more::AsRef added, one can now use as_ref method to borrow the underlying byets slice. Whilo at it. Replace explicit From implementation by derive_more::Into and get rid of unnecessary clone inside of conversion into MerkleProof.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
==========================================
- Coverage 70.69% 70.69% -0.01%
==========================================
Files 178 178
Lines 17870 17868 -2
==========================================
- Hits 12634 12631 -3
- Misses 5236 5237 +1 ☔ View full report in Codecov by Sentry. |
Farhad-Shabani
approved these changes
Dec 18, 2023
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* feat: derive AsRef for CommitmentProofBytes Derive AsRef for CommitmentProofBytes so it’s possible to access its underlying bytes without having to own it. The type can be converted into Vec but that requires ownership. If all one has is a reference to the proof bytes (as in verify_membership method for example), there’s no way to access underlying bytes without cloning it first. With derive_more::AsRef added, one can now use as_ref method to borrow the underlying byets slice. Whilo at it. Replace explicit From implementation by derive_more::Into and get rid of unnecessary clone inside of conversion into MerkleProof. * log * nit: remove now redundant clones * chore: remove redundant conversion to MerkleProof from owned CommitmentProofBytes --------- Co-authored-by: Farhad Shabani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derive AsRef for CommitmentProofBytes so it’s possible to access its
underlying bytes without having to own it.
The type can be converted into Vec but that requires ownership. If
all one has is a reference to the proof bytes (as in verify_membership
method for example), there’s no way to access underlying bytes without
cloning it first.
With derive_more::AsRef added, one can now use as_ref method to borrow
the underlying bytes slice.
While at it. Replace explicit From implementation by derive_more::Into
and get rid of unnecessary clone inside of conversion into MerkleProof.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.