-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom HostFunctionsProvider
in MerkleProof
#1158
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
+ Coverage 63.76% 63.79% +0.03%
==========================================
Files 219 219
Lines 21387 21391 +4
==========================================
+ Hits 13638 13647 +9
+ Misses 7749 7744 -5 ☔ View full report in Codecov by Sentry. |
Hey @mina86, See please changes in this PR meet your requirements? This follows a similar approach we took for enabling a custom Tendermint Verifier. Meaning that, so far, we've been using a concrete Note that to enable the Therefore, take this as an interim solution. Let us know your thoughts. Happy to help in any way we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be sufficient for our needs.
* feat: allow HostFunctionsProvider in MerkleProof * nit: consistent generic name H * feat: use hash_with<H> for hashing validator sets * fix: make verify_upgrade_client func generic over HostFunctionsProvider * chore: add changelog
Closes: #1147
Integration tests: informalsystems/basecoin-rs#174
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.