Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ibc-clients): upload Tendermint CosmWasm client as workflow artifact #1173

Merged
merged 17 commits into from
Apr 20, 2024

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Apr 18, 2024

Closes: #1170

Example workflow run: 8738022488.

  • Compiles Tendermint CosmWasm client via cosmwasm/optimizer.
  • Runs cosmwasm-check on the compiled cw contract.
  • Uploads the wasm file as Github workflow artifact.

Also, contains an example job to download the artifact at remote repository.

References:

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy requested a review from Farhad-Shabani April 18, 2024 12:31
@rnbguy rnbguy marked this pull request as ready for review April 18, 2024 12:44
@rnbguy rnbguy changed the title ci(ibc-clients): upload Tendermint wasm08 client as workflow artifact ci(ibc-clients): upload Tendermint CosmWasm client as workflow artifact Apr 19, 2024
cancel-in-progress: true

jobs:
upload-tm-wasm08-client:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
upload-tm-wasm08-client:
upload-tendermint-cw-client:

This should be adjusted for other places where wasm08 used. Actually, the 08-wasm is a distinct type of light client that enables operating the CosmWasm contract of other clients like in our case the CosmWasm contract of the Tendermint.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Left just a small comment.

@rnbguy rnbguy added this pull request to the merge queue Apr 20, 2024
Merged via the queue into main with commit 80b8084 Apr 20, 2024
17 checks passed
@rnbguy rnbguy deleted the rano/ci/upload-wasm-artifacts branch April 20, 2024 11:48
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
…ct (#1173)

* tendermint wasm08 client as workflow artifact

* rm retention days

* lints on comments

* conditional retention days

* use actions-rust-lang over dtolnay

* imp docker run

* use cosmwasm/optimizer 0.15.1

* correct mount paths

* validate checksum

* s/wasm08/cosmwasm

* .yaml over .yml

* install cargo binary before wasm compile to avoid docker mount permission

* fix permissions manually

* use id

* tendermint over tm

* document tendermint cw artifact

* grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICS-07 CosmWasm contract build needs CI + Nix flake
2 participants