Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ics20): PrefixedDenom parsing #1178

Merged
merged 52 commits into from
Apr 26, 2024
Merged

fix(ics20): PrefixedDenom parsing #1178

Show file tree
Hide file tree
Changes from 51 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
c81f2da
add failing test
rnbguy Apr 19, 2024
6c0a324
add TracePath::new
rnbguy Apr 19, 2024
ad096f5
imp PrefixedDenom parsing
rnbguy Apr 19, 2024
08710f6
add validate_named_u64_index
rnbguy Apr 19, 2024
9d2a9ea
validate_named_u64_index in channel and connection validation
rnbguy Apr 19, 2024
eba0690
add tests for validate_named_u64_index
rnbguy Apr 19, 2024
dfac6b5
update PrefixDenom parsing tests
rnbguy Apr 19, 2024
be171a1
update accepted cases in ibc-go
rnbguy Apr 19, 2024
e59060e
update accepted cases
rnbguy Apr 19, 2024
04b40dc
add test cases from ibc-go
rnbguy Apr 19, 2024
a9b8d8b
use valid connection id
rnbguy Apr 19, 2024
6542a23
failing doc tests
rnbguy Apr 19, 2024
3337f65
use existing constants
rnbguy Apr 19, 2024
a88e1d2
changelog entry
rnbguy Apr 19, 2024
dd021d9
refactor tests
rnbguy Apr 19, 2024
4a7c034
apply suggestions from code review
rnbguy Apr 20, 2024
9d246d4
add comment for PrefixedDenom::from_str
rnbguy Apr 20, 2024
be0f693
rm TracePath::new
rnbguy Apr 20, 2024
02d57c8
collect the same tests
rnbguy Apr 20, 2024
b1804b0
test parsed PrefixedDenom string repr
rnbguy Apr 20, 2024
baedfb7
test trace order
rnbguy Apr 20, 2024
32f5407
more tests
rnbguy Apr 20, 2024
e3c109b
update tests
rnbguy Apr 20, 2024
dfe5a7c
rm redundant error variant
rnbguy Apr 20, 2024
5dd5559
refactor tests
rnbguy Apr 20, 2024
5d04ebf
update doc string
rnbguy Apr 20, 2024
50ebb2f
add comment on virtual split_twice
rnbguy Apr 20, 2024
063c1df
update doc str
rnbguy Apr 20, 2024
f72517f
add TracePrefix::strip and TracePath::trim
rnbguy Apr 22, 2024
25111df
add whitespace cases
rnbguy Apr 22, 2024
76cf402
refactor tests
rnbguy Apr 22, 2024
1524a50
spelling
rnbguy Apr 22, 2024
8720be0
parse over from_str
rnbguy Apr 22, 2024
93a81d5
nit
rnbguy Apr 22, 2024
2abbeab
Merge branch 'main' into rano/fix/parsing-prefixed-denom
seanchen1991 Apr 22, 2024
94ac941
apply suggestions from code review
rnbguy Apr 22, 2024
7408994
add failing test
rnbguy Apr 24, 2024
d34d946
fix TracePath::from_str
rnbguy Apr 24, 2024
03b08d7
fix parsing
rnbguy Apr 24, 2024
29be17b
fix test
rnbguy Apr 24, 2024
2b11733
add ibc-app-transfer-types dep
rnbguy Apr 24, 2024
1eecc2b
rm reusable code
rnbguy Apr 24, 2024
6ff2abf
update impls
rnbguy Apr 24, 2024
bd7922e
update tests
rnbguy Apr 24, 2024
736d4a1
accepted class ids
rnbguy Apr 24, 2024
badb018
refactor tests
rnbguy Apr 24, 2024
eb9456f
update changelog entry
rnbguy Apr 24, 2024
43e46ad
opt trace prefix and path parsing
rnbguy Apr 25, 2024
a784640
add new tests
rnbguy Apr 25, 2024
7f465b0
Update changelog entry
seanchen1991 Apr 26, 2024
6f3eddb
Merge branch 'main' into rano/fix/parsing-prefixed-denom
seanchen1991 Apr 26, 2024
53fad12
fix trace-prefix index order
rnbguy Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changelog/unreleased/bug-fixes/1177-fix-prefixed-denom-parsing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
- [ibc-app-transfer] Bring `PrefixedDenom` parsing up to parity with `ibc-go`.
([\#1177](https://github.com/cosmos/ibc-rs/issues/1177))
- [ibc-app-nft-transfer] Reuse `TracePrefix` and `TracePath` from
`ibc-app-transfer-types` when parsing `PrefixedClassId`.
([\#1178](https://github.com/cosmos/ibc-rs/pull/1178))
Loading
Loading