imp(testkit): integration test for packet timeout #1215
Conversation
this verifies non-membership proofs
rnbguy
changed the title
|
Let's merge this only after informalsystems/basecoin-rs#141 is merged. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
+ Coverage 66.34% 67.31% +0.97%
==========================================
Files 234 234
Lines 23328 23553 +225
==========================================
+ Hits 15477 15855 +378
+ Misses 7851 7698 -153 ☔ View full report in Codecov by Sentry. |
ibc-testkit/src/relayer/context.rs
Outdated
| @@ -356,4 +356,183 @@ where | |||
| signer, | |||
| ) | |||
| } | |||
|
|
|||
| /// Timeouts a packet from the first context to the second context. | |||
There was a problem hiding this comment.
This language is a bit ambiguous when it comes to delineating whether a packet sent between the two contexts was expired, or if an actual timeout packet was sent.
The code seems to indicate the latter, in which case we should say "Sends a timeout packet from the first context to the second context."
There was a problem hiding this comment.
I agree with you. I updated the comments and the method names.
rnbguy
force-pushed
the
rano/testkit/packet-timeout
branch
from
3abc78e to
7787301
Compare
* use basecoin rev * rm RevertibleStore and GrowingStore use * add packet timeout integration test this verifies non-membership proofs * reorder imports * add timeout_packet_on_channel_close_on_a in utils * add timeout_packet_on_channel_close_on_a in context * test for packet timeout on channel close * use correct event type * validate packet events * rm dbg * add send_packet_via_dummy_transfer_module_on_a method * use the new method * add changelog entry * update doc links * fix link in doc-strings * fix for serde feature * basecoin main branch * fix unused imports * cargo format * fix link in doc-strings * fix method names and comments
Closes: #398
Closes: #1217
Description
Integration tests for:
Also, reproduces the bug from #1217.
The latest branch from
basecoin-rsnow has non-membership proofs for its IAVL tree.This PR adds a packet timeout scenario to our existing integration test. This exercises non-membership proof for the Tendermint light client.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.