-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add optional arbitrary impls #1390
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
- Coverage 67.35% 67.09% -0.26%
==========================================
Files 225 226 +1
Lines 22393 22425 +32
==========================================
- Hits 15082 15047 -35
- Misses 7311 7378 +67 ☔ View full report in Codecov by Sentry. |
Can you please fix the typos |
arbitrary = [ | ||
"ibc-core-client/arbitrary", | ||
"ibc-core-connection/arbitrary", | ||
"ibc-core-commitment-types/arbitrary", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ibc-core-channel/arbitrary
is missed. and router too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added ibc-core-channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tzemanovic Thanks for correctly adding ibc-core-commitment-types/arbitrary
. It looks like, we forgot it for parity-scale-codec
😅 Can you please add it for us? (or give us permission to push commits to your branch)
I don't have write access to your branch. Can you add ibc-rs/.github/workflows/rust.yaml Line 128 in edb36f7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Description
This adds
Arbitrary
impl for some types behind a newly added feature "arbitrary" that can be used for e.g. prop and fuzz testingImplements the following methods to be used for
arbitrary(with = ..)
PR author checklist:
unclog
.docs/
). - no relevant docs sectionReviewer checklist:
Files changed
in the GitHub PR explorer.