Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cw-check to comply with ibc restructuring changes #977

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

Farhad-Shabani
Copy link
Member


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4421b0d) 70.24% compared to head (28872d1) 70.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #977   +/-   ##
=======================================
  Coverage   70.24%   70.24%           
=======================================
  Files         177      177           
  Lines       17730    17730           
=======================================
  Hits        12455    12455           
  Misses       5275     5275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review November 22, 2023 16:48
Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Farhad-Shabani Farhad-Shabani merged commit 4596f88 into main Nov 22, 2023
15 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/fix-cw-check branch November 22, 2023 17:43
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants