feat: add api folder containing pulsar generated code. #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
added
go
10 tasks
|
Thanks @DimitrisJim! Happy to leave this open or switch to draft. Likely won't need to merge this if we don't need protov2 and can use gogoproto. |
|
moving to draft per Damian's comment! |
|
This can be closed as pulsar is no longer required. see cosmos/cosmos-sdk#20134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for cosmos/ibc-go#5968
Protos contain only primitive types so generation was straigh-forward. Would be a good idea to add a step to the go workflow that enters the mod and does a sanity
go build ./...