Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation #1

Merged
merged 2 commits into from
Sep 23, 2021
Merged

documentation #1

merged 2 commits into from
Sep 23, 2021

Conversation

jonapich
Copy link
Collaborator

@jonapich jonapich commented Sep 21, 2021

make all bullet points the same before jfsmith sees them
Copy link

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation LGTM concerning what's the project is. I'll only give a consultative review tho (no ✔️ nor ❌) because of my lack of knowledge of the python environment.

Ideas/improvement:
From my understanding, the 'automatic next version' will always be the x.y.z+1 where, {x,y,z} is the 'greatest' semantic version. And this, regardless of the changeset that occurred since {x.y.z}.

An improvement would be to use the git history between the git ref being built & the greatest tag on the main or branch version to define the latest version. (this would ofc work only if the commits are semantics)

https://github.com/relekang/python-semantic-release seems to do just that and has a fair amount of traction. ( 90k download last month, 363 ⭐ ). Did you check it out?

Regardless of the above, GH Release associated with the tag would be nice too.

@jonapich
Copy link
Collaborator Author

An improvement would be to use the git history between the git ref being built & the greatest tag on the main or branch version to define the latest version. (this would ofc work only if the commits are semantics)

I did fool around with such a tool, but I found it was adding one more layer of technicality and human error over the repository for not much gain. They're probably far more useful / necessary in high-velocity repositories where merges occur frequently.

That being said, I realize the current functionality prevents users from using such a system, so I wrote #4 and #5 to ensure we can at least play hand-in-hand.

Regardless of the above, GH Release associated with the tag would be nice too.

Hey that's right! #3 😄

Copy link

@klalumiere klalumiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

As a new feature, do you think it would worth it to parameterize the server so that we can use an internal one? 🤔

@jonapich jonapich merged commit 1f75784 into main Sep 23, 2021
@jonapich jonapich deleted the feature/documentation branch September 23, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants