-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Restore the custom naming based on config location (#44)
The initial goal was to easily identify custom images instead of just having an anonymous hash to identify them. We then added a hash to ensure that we rebuild the image if the custom DockerFile or the custom build folder content changed and finally, we removed the name, thus loosing the identification of the custom image and returning to an anonymous image as we did originally. It is still important to not rebuild the custom image if there is no change and rebuild it if there is a change. So, I simply added the hash into a label and instead putting the hash into the name, we simply check if the label has changed to determine if the image should be rebuilt.
- Loading branch information
Showing
4 changed files
with
31 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters