Classify objects #59
Merged
Classify objects #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| #hasPing = false; | ||
|
|
||
| constructor() { |
danthedaniel
approved these changes
Jan 1, 2025
| * Clear the favicon state and update the display | ||
| */ | ||
| clear() { | ||
| this.#messageCount = 0; |
There was a problem hiding this comment.
Private variables! I've never use those in JS.
There was a problem hiding this comment.
Yeah they are quite neat. Relatively recent but old enough that they are supported in any browser of the last few years.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danthedaniel back from the death(backlog)! ;)
managers/favicon_manager.mjsmanagers/server_info.mjsmanagers/player_list.mjsAnd a few other changes as well that made sense in this context:
querySelectorWithAssertionfunction is now part ofutils.mjs