feat(auth): allow optional basic authentication (backport #95)

[mergify]

This is an automatic backport of pull request #95 done by Mergify.

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

[ebaron]

@tthvo CI is failing for this one. Only the backport strangely. It seems to be upgrade related, but I'm having trouble pinpointing the cause in the logs. If it is upgrade related, it could be something similar to #82 (comment).

[tthvo]

Ahh hmm, I remember handling that null case in...36ff259 (in #95).

I am not seeing Error: UPGRADE FAILED: ... in logs as before. But i saw these:

2023-10-25T23:07:16.3718485Z 72s Warning FailedScheduling pod/cryostat-v4lou3pxqe-85c5dccd49-h6r8n default-scheduler 0/1 nodes are available: 1 node(s) had untolerated taint {node.kubernetes.io/not-ready: }. preemption: 0/1 nodes are available: 1 Preemption is not helpful for scheduling.. 72s 1 cryostat-v4lou3pxqe-85c5dccd49-h6r8n.17917c439e48d520

Error: pod cryostat-v4lou3pxqe-test-connection failed
Upgrade testing for release "cryostat-v4lou3pxqe" skipped because of previous revision testing error: failed waiting for process: exit status 1

Might just be kind issue?

[tthvo]

Ahh hahaha oh my. I figured it was because there is a mismatched between Chart.yaml and the core image AppVersion.

• On this branch, Chart.yaml has 2.4.0-dev as AppVersion while the core is latest (which is 2.5.0-dev.
• The test checks for this AppVersion as part of the connection tests>

cryostat-helm/charts/cryostat/templates/tests/test-connection.yaml

Line 20 in e6be8ea

jq -e '{{ printf "(.cryostatVersion | test(\"^v%s\")) and .datasourceAvailable == %t" (.Chart.AppVersion | squote) (not .Values.minimal) }}' /tmp/out.json;

This patch will make the test pass:

diff --git a/charts/cryostat/Chart.yaml b/charts/cryostat/Chart.yaml
index 49a8052..0a4c97a 100644
--- a/charts/cryostat/Chart.yaml
+++ b/charts/cryostat/Chart.yaml
@@ -8,7 +8,7 @@ version: "0.4.0-dev"
 
 kubeVersion: ">= 1.19.0-0"
 
-appVersion: "2.4.0-dev"
+appVersion: "2.5.0-dev"
 
 home: "https://cryostat.io"

[tthvo]

I guess we should update the tags of images in values.yaml to 2.4.0 release.

[ebaron]

Ah, that explains it! I think we need to add some steps to do this for the operator and Helm Chart when branching for release.

[tthvo]

Sounds good! I might have missed that when documenting these steps haha^^

[ebaron]

@Mergifyio rebase

[mergify]

rebase

❌ Unable to rebase: user ebaron is unknown.

Please make sure ebaron has logged in Mergify dashboard.

[ebaron]

@Mergifyio rebase

[mergify]

rebase

❌ Base branch update has failed

Git reported the following error:

Rebasing (1/1)
Auto-merging charts/cryostat/README.md
CONFLICT (content): Merge conflict in charts/cryostat/README.md
Auto-merging charts/cryostat/values.schema.json
Auto-merging charts/cryostat/values.yaml
error: could not apply 5ad3810... feat(auth): allow optional basic authentication (#95)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 5ad3810... feat(auth): allow optional basic authentication (#95)

[ebaron]

Finally got it fixed!