-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(selector): select Cryostat instances by labelled Services #5
feat(selector): select Cryostat instances by labelled Services #5
Conversation
@aptmac use in conjunction with cryostatio/cryostat-helm#211 : $ cd cryostat-helm
$ gh pr checkout 211
$ oc new-project test
$ helm install --set authentication.openshift.enabled=true --set core.route.enabled=true mycryostat ./charts/cryostat
$ cd -
$ cd cryostat-openshift-console-plugin
$ # install the plugin, or run it locally, and verify that the instance selector shows "mycryostat (test)" as an option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only nit I can find is that yarn needs to be manually set up here; without creating a .yarn/releases/
and populating it with a yarn-3.6.3.cjs
trying to install or run anything will run into issues. I see that cryostat-web includes this folder in it's repo, do you think we should just do the same here as well?
Otherwise, LGTM
Depends on cryostatio/cryostat-helm#211
Depends on cryostatio/cryostat-operator#974
Fixes #2