Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(selector): select Cryostat instances by labelled Services #5

Merged
merged 14 commits into from
Jan 9, 2025

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Nov 19, 2024

  • rename
  • update cryostat-web commit, dependencies
  • setup
  • select by labeled Service, not Cryostat CR
  • correct yarn setup
  • configure sources path
  • deps update

Depends on cryostatio/cryostat-helm#211
Depends on cryostatio/cryostat-operator#974
Fixes #2

@andrewazores
Copy link
Member Author

@aptmac use in conjunction with cryostatio/cryostat-helm#211 :

$ cd cryostat-helm
$ gh pr checkout 211
$ oc new-project test
$ helm install --set authentication.openshift.enabled=true --set core.route.enabled=true mycryostat ./charts/cryostat
$ cd -
$ cd cryostat-openshift-console-plugin
$ # install the plugin, or run it locally, and verify that the instance selector shows "mycryostat (test)" as an option

@andrewazores andrewazores marked this pull request as ready for review December 10, 2024 14:28
@aptmac aptmac self-assigned this Dec 17, 2024
@aptmac aptmac self-requested a review December 17, 2024 16:23
@aptmac aptmac removed their assignment Dec 17, 2024
Copy link
Member

@aptmac aptmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only nit I can find is that yarn needs to be manually set up here; without creating a .yarn/releases/ and populating it with a yarn-3.6.3.cjs trying to install or run anything will run into issues. I see that cryostat-web includes this folder in it's repo, do you think we should just do the same here as well?

Otherwise, LGTM

@andrewazores andrewazores merged commit 0f2cfb4 into cryostatio:main Jan 9, 2025
1 check passed
@andrewazores andrewazores deleted the select-labeled-services branch January 9, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CR-based instance selection implies Operator dependency
2 participants